On Sun, Nov 01, 2015 at 11:54:38AM +0900, Mark Brown wrote:
> On Fri, Oct 30, 2015 at 08:34:18PM +0530, Vinod Koul wrote:
> > From: Jeeja KP <jeeja.kp@xxxxxxxxx>
> >
> > The UEFI BIOS does not create a machine entry for Linux devices
> > so add a table style machine registration to fix this missing
> > entry
>
> How does this relate to the existing sst_acpi code? This might be
> clearer with a user...
It is similar but sst_machines structure is entirely different. In Skylake
case we only need machine entry name and rest of the information is coming
from topology manifest data. I will try to move this as well to topology
data later, but for now on upstream to get audio out from boards I need this
patch :)
I am not sure I follow the comment on user, the SKL driver here is user in
this
> > +static struct sst_machines *sst_acpi_find_machine(
> > + struct sst_machines *machines)
> > +{
> > + struct sst_machines *mach;
> > + bool found = false;
> > +
> > + for (mach = machines; mach->codec_id; mach++)
> > + if (ACPI_SUCCESS(acpi_get_devices(mach->codec_id,
> > + sst_acpi_mach_match,
> > + &found, NULL)) && found)
> > + return mach;
> > +
> > + return NULL;
> > +}
>
> ...but the code looks extremely similar.
as explained above code is similar but everyone uses different sst_machines
strcuture.
--
~Vinod
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
