On Thu, Oct 22, 2015 at 10:43:23AM +0200, Lars-Peter Clausen wrote:
> The rate constraints in this driver are shared between all device
> instances. It should not be (and is not) modified at runtime, so make them
> const.
>
> While we are at it also change the type of the rates array from u32 to
> unsigned int. While both resolve to the same type, u32 is usually used to
> empathize that the value is for a 32-bit hardware register or similar which
> makes it slightly confusing in this context.
>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Acked-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>
> ---
> sound/soc/fsl/fsl_sai.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 784725b..38505f3 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -27,13 +27,13 @@
> #define FSL_SAI_FLAGS (FSL_SAI_CSR_SEIE |\
> FSL_SAI_CSR_FEIE)
>
> -static u32 fsl_sai_rates[] = {
> +static const unsigned int fsl_sai_rates[] = {
> 8000, 11025, 12000, 16000, 22050,
> 24000, 32000, 44100, 48000, 64000,
> 88200, 96000, 176400, 192000
> };
>
> -static struct snd_pcm_hw_constraint_list fsl_sai_rate_constraints = {
> +static const struct snd_pcm_hw_constraint_list fsl_sai_rate_constraints = {
> .count = ARRAY_SIZE(fsl_sai_rates),
> .list = fsl_sai_rates,
> };
> --
> 2.1.4
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
