On Sat, Oct 17, 2015 at 11:11:10AM +0800, Axel Lin wrote: > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx> > --- > I think the intention of wm8904_readable_register is to return false for > undocumented registers, but current code returns true for all cases in > wm8904_readable_register. > Please review if this patch is correct or not. > Thanks. Ok so I have been through every register access in the driver (yes that was a bit boring) and it looks like the driver only accesses a register that isn't marked as readable once. But this looks to be a bug. WM8904_EQ_REGS is set to 25, but there are only 24 registers in the EQ. This appears to be a mistake caused by the fact the registers start numbering from 1 rather than 0. I will send a patch to fix this small bug and this patch looks fine to me: Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> Unfortunately I don't have hardware to test the patch, but I have reviewed it pretty carefully and am happy. Thanks, Charles _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
