Re: [PATCH 08/10] ALSA: usb-audio: UAC2: auto clock selection module param

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, 2 Apr 2013, Takashi Iwai wrote:

> At Sun, 31 Mar 2013 17:52:30 +0200,
> Eldad Zack wrote:
> > 

> > +module_param(noautoclk, bool, 0444);
> > +MODULE_PARM_DESC(noautoclk, "Disables auto-clock selection for UAC2 devices.");
> 
> Don't use "no" for a boolean option.  You can pass "yes" or "no" as an
> option value, so it can confuse easily by passing noautoclk=yes.  See?

Ah, I understand. Good point. I'll change it to autoclock like you 
suggested (also internally).

Thanks!

I'll add some text to the other patch and repost.

Cheers,
Eldad
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux