On Fri, Dec 10, 2010 at 09:05:35PM -0600, Olaya, Margarita wrote: > From: Jorge Eduardo Candelaria <jorge.candelaria@xxxxxx> > > Updated default values to improve power consumption. > > Signed-off-by: Jorge Eduardo Candelaria <jorge.candelaria@xxxxxx> > Signed-off-by: Margarita Olaya Cabrera <magi.olaya@xxxxxx> It'd be much more idiomatic to do this by having writes in the driver startup path and adding comments to explain why the defaults are being changed. Altering the table with no explanation in the code means that someone could quite easily come along later and correct the values back to the actual chip defaults, and means that someone could get surprised if they write code which assumes these are the actual chip defaults later on. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
