At Fri, 10 Dec 2010 17:34:26 +0800, Axel Lin wrote: > > It does not make sense to set clientdata to onyx in onyx_i2c_remove() > as we are going to kfree onyx. > What we really want here is i2c_set_clientdata(client, NULL); > Since the i2c core will take care of it now, so this patch just removes it. > > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx> Thanks, applied now. Takashi > --- > sound/aoa/codecs/onyx.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c > index 91852e4..3687a6c 100644 > --- a/sound/aoa/codecs/onyx.c > +++ b/sound/aoa/codecs/onyx.c > @@ -1114,7 +1114,6 @@ static int onyx_i2c_remove(struct i2c_client *client) > of_node_put(onyx->codec.node); > if (onyx->codec_info) > kfree(onyx->codec_info); > - i2c_set_clientdata(client, onyx); > kfree(onyx); > return 0; > } > -- > 1.7.2 > > > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel