At Wed, 24 Nov 2010 10:11:00 +0000, Mark Brown wrote: > > On Wed, Nov 24, 2010 at 10:05:05AM +0100, Takashi Iwai wrote: > > Mark Brown wrote: > > > On Mon, Nov 22, 2010 at 07:09:43PM +0530, ramesh.babu@xxxxxxxxx wrote: > > > > > + intelhaddata = device->device_data; > > > > This function doesn't appear to do anything like what either the > > > description or name would suggest? I'd expect to see some deallocation > > > going on... > > > Reading through the code, the construct doesn't seem to allocate any > > private stuff but only standard components, so this callback doesn't > > have to do anything much, I suppose. > > To be honest half the issue was the above quoted line - if the function > had been empty I'd have been less concerned (and probably just said to > remove it). I understand better now :) Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
