Re: [PATCHES] Integrate minimal systemd support in alsa-utils

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 23 Nov 2010, Lennart Poettering wrote:

> On Tue, 23.11.10 10:44, Jaroslav Kysela (perex@xxxxxxxx) wrote:
>
> Heya,
>
>>> Up to this point most distributions have been using different init
>>> scripts/udev rules files to save/restore mixer settings at
>>> boot/hotplug/shutdown. Please see my two attached patches for alsa-utils
>>> which add standardized, simplified support for this.
>>>
>>> The first patch is stolen from Debian/Ubuntu, which moves asound.state
>>> to /var/lib, which is a more appropriate place, since /etc might be
>>> read-only.
>>
>> This will break users which upgrade the package manually from sources and
>> /var/lib/alsa directory is not created. I think that the 'make
>> install' rules should create this directory and also alsaconf should
>> check/create this directory if it does not exists.
>
> See attached patch. This will now ensure the directory is created both
> at install time and when alsaconf is run.
>
> Also, I made the path configurable, as requested by Takashi, however
> set the default to /var/lib/alsa.

I applied your patch. Just only one comment: The better location for the 
install-data-hook is the alsactl/Makefile.am.

 						Jaroslav

-----
Jaroslav Kysela <perex@xxxxxxxx>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux