Re: [PATCHv4 17/18] ASoC: Samsung: Generalize Kconfig symbols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 23, 2010 at 11:12 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Nov 22, 2010 at 03:37:22PM +0900, Jassi Brar wrote:
>
>> Â Â Â Â SND_SOC_SMDK_SPDIF -> ASOC_SAMSUNG_SMDK_SPDIF
>> Â Â Â Â SND_SOC_SMDK_WM8580 -> ASOC_SAMSUNG_SMDK_WM8580
>> Â Â Â Â SND_SOC_SMDK_WM9713 -> ASOC_SAMSUNG_SMDK_WM9713
>> Â Â Â Â SND_SOC_GONI_AQUILA_WM8994 -> ASOC_GONI_AQUILA_WM8994
>
> Hrm. ÂThese ones I'm not entirely happy about - we're pretty
> consistently using SND_SOC_ rather than ASOC_ throughout the subsystem
> so changing to ASOC_ feels like churn. ÂIs there any great reason for
> the rename? ÂI don't mind the addition of SAMSUNG_ one way or the other,
> it's just the subsystem prefix.
If SND_SOC is to be used across all platforms, my changes are indeed
out of line.
Otherwise, ASOC represents SND_SOC better and compactly.

> I've applied this just now as the rename patch depends on it.
Ok, though I was/am willing to submit yet another revision.

Thanks.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux