On Wed, Nov 10, 2010 at 7:13 AM, Liam Girdwood <lrg@xxxxxxxxxxxxxxx> wrote: > On Tue, 2010-11-09 at 15:43 -0600, abraham duenas wrote: >> >From f796e5f464d3454761b618912e5b4d14716c2bfc Mon Sep 17 00:00:00 2001 >> From: abraham duenas <abraham.duenas@xxxxxx> >> Date: Tue, 9 Nov 2010 15:31:16 -0600 >> Subject: [PATCH] add missing comparison to strcmp call >> > > Could do with a little more description here. > >> >> Signed-off-by: abraham duenas <abraham.duenas@xxxxxx> >> --- >> src/ucm/main.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/ucm/main.c b/src/ucm/main.c >> index e233f41..a73595d 100644 >> --- a/src/ucm/main.c >> +++ b/src/ucm/main.c >> @@ -774,9 +774,9 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr, >> pthread_mutex_lock(&uc_mgr->mutex); >> if (strcmp(identifier, "_verbs") == 0) >> err = get_verb_list(uc_mgr, list); >> - else if (strcmp(identifier, "_enadevs")) >> + else if (strcmp(identifier, "_enadevs") == 0) >> err = get_enabled_device_list(uc_mgr, list); >> - else if (strcmp(identifier, "_enamods")) >> + else if (strcmp(identifier, "_enamods") == 0) >> err = get_enabled_modifier_list(uc_mgr, list); >> else { >> str1 = strchr(identifier, '/'); > > Looks fine to me, did this solve all your parsing issues ? > > Thanks > > Liam > -- > Freelance Developer, SlimLogic Ltd > ASoC and Voltage Regulator Maintainer. > http://www.slimlogic.co.uk > > Not completely... I'm getting the "cset not yet implemented..." warning for the last element in the row. This is, for this sequence: cset "name='Master Playback Switch' 1,1" cset "name='Master Playback Volume' 25,25" cset "name='Master Mono Playback' 0" I only get the warning for the last cset call: "cset not yet implemented: 'name='Master Mono Playback' 0' _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel