Re: [PATCH 1/4] ASoC: soc.h: Add new caching API prototypes and hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 04, 2010 at 02:22:41PM +0000, Dimitris Papastamos wrote:

> Signed-off-by: Dimitris Papastamos <dp@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

As previously mentioned please split this series up into patches which
individually add some useful functiionality 

> +/* SoC cache ops */
> +struct snd_soc_cache_ops {
> +	int id; /* corresponds to snd_soc_compress_type */

Shouldn't this be using the enum then?

> --- a/sound/soc/Kconfig
> +++ b/sound/soc/Kconfig
> @@ -4,6 +4,8 @@
>  
>  menuconfig SND_SOC
>  	tristate "ALSA for SoC audio support"
> +	select LZO_COMPRESS
> +	select LZO_DECOMPRESS
>  	select SND_PCM
>  	select AC97_BUS if SND_SOC_AC97_BUS
>  	select SND_JACK if INPUT=y || INPUT=SND

This definitely looks like it should be in a separate patch.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux