On 30/10/10 08:35, Jesper Juhl wrote: > I noticed that sound/pci/asihpi/hpicmn.c::hpi_alloc_control_cache() does > not check the return value from kmalloc(), which may fail. > If kmalloc() fails we'll dereference a null pointer and things will go bad > fast. > There are two memory allocations in that function and there's also the > problem that the first may succeed and the second may fail and nothing is > done about that either which will also go wrong down the line. Thanks Jesper, your changes look fine. Acked-by: Eliot Blennerhassett <linux@xxxxxxxxxxxxxxxx> _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel