On Fri, Oct 22, 2010 at 03:28:19PM +0100, Dimitris Papastamos wrote: > Signed-off-by: Dimitris Papastamos <dp@xxxxxxxxxxxxxxxxxxxxxxxxxxx> Where possible you should try to split your series up such that each is useful individually - splitting things up by file is mostly done for the addition of large new blocks of code. This means that the patches can be applied one at a time without leaving the tree in an "interesting" state. > +int snd_soc_cache_sync(struct snd_soc_codec *codec); > +int snd_soc_cache_init(struct snd_soc_codec *codec); > +int snd_soc_cache_deinit(struct snd_soc_codec *codec); > +int snd_soc_cache_write(struct snd_soc_codec *codec, > + unsigned int reg, unsigned int value); > +int snd_soc_cache_read(struct snd_soc_codec *codec, > + unsigned int reg, unsigned int *value); For example, a patch adding the cache operations but supporting only the current flat cache would introduce the cache API and factor out some code usefully by itself. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
