Re: [patch 3/3] Staging: sst: fixups in SNDRV_SST_STREAM_DECODE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> This is another patch about copying data to the kernel before using it.
> 
> SNDRV_SST_STREAM_DECODE is sort of tricky because we need to do a
> copy_from_user() that gives us another two pointers and we have copy
> those.  Those again give us some more pointers that we have to copy.
> 
> Besides those problems, the code had a stack overflow:
> -	struct snd_sst_buff_entry ibuf_temp[param->ibufs->entries],
> -		obuf_temp[param->obufs->entries];
> param->ibufs->entries comes from the user.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
Acked-by: Vinod Koul <vinod.koul@xxxxxxxxx>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux