Re: [PATCH 2/2] ASoC: ak4642: simultaneous playback/recorde support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 12, 2010 at 01:39:25PM +0900, Kuninori Morimoto wrote:

>  		ak4642_write(codec, 0x09, 0x91);
>  		ak4642_write(codec, 0x0c, 0x91);
> -		ak4642_write(codec, 0x00, 0x64);
> +		snd_soc_update_bits(codec, 0x00, 0x64, 0x64);

Applied, but given all the magic numbers this is pretty much illegible -
it'd be good if when updating the driver you could start to convert the
magic numbers into #defines.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux