On Wed, Oct 06, 2010 at 08:24:44AM +0200, Takashi Iwai wrote: > BTW, looking through the changes, I wonder why only > snd_soc_4_12_spi_write has the byte swap at copying msg[]. Is it > intended or a typo? If this is a typo, we can merge all > snd_soc_*_spi_write() into a single function. It's not a byte swap, it's mangling part of the register and value together. The others are using whole numbers of bytes. > And, all snd_soc_x_y_read() and snd_soc_x_y_write() are fairly > resemble, just data[] setup is different. They can be merged well, I > suppose. They also differ in the type of the cache variable. You could do something with macros but it'd not be terribly pleasant. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
