Re: [PATCH] ASoC: WM8804: Initial driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-09-29 at 11:14 +0100, Dimitris Papastamos wrote:
> The WM8804 is a high performance consumer mode
> S/PDIF transceiver with support for 1 received channel and
> 1 transmitted channel.
> 
> Signed-off-by: Dimitris Papastamos <dp@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  sound/soc/codecs/Kconfig  |    4 +
>  sound/soc/codecs/Makefile |    2 +
>  sound/soc/codecs/wm8804.c |  820 +++++++++++++++++++++++++++++++++++++++++++++
>  sound/soc/codecs/wm8804.h |   61 ++++
>  4 files changed, 887 insertions(+), 0 deletions(-)
>  create mode 100644 sound/soc/codecs/wm8804.c
>  create mode 100644 sound/soc/codecs/wm8804.h
> 

Acked-by: Liam Girdwood <lrg@xxxxxxxxxxxxxxx>

but

> +
> +static struct snd_soc_dai_driver wm8804_dai = {
> +	.name = "wm8804-s/pdif",

There may be per DAI debugfs or sysfs info in the future so it's best to
not use a "/" in a name. Can you do an incremental change.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux