On Wed, 2010-09-29 at 10:43 -0700, Mark Brown wrote: > Note that the whole callback thing is more important for things with > idle_bias_off (which might get the regulators powered down at runtime) > than for other things which don't go down to _BIAS_OFF at runtime so > would only trigger the callback on suspend anyway. Ok I will revert this patch then. The reason why I did not set idle_bias_off is that I could not guarantee that the driver would still function properly without testing it. > Always split different things out into separate patches unless they > overlap with each other a lot. Yup indeed. > It's better to restructure the code so that the compiler is able to > follow the control flow and see that there's no uninitialised access - > this sort of change will just shut up legitimate warnings as well. Some > of the other CODEC drivers (wm8400 is one) have had similar changes > which seem to do the trick. My version of GCC (4.5.1) does not seem to have a problem figuring out the flow of execution. It is just that some of the people who use this code and have an older version of GCC get these warnings. I agree this is not the way to fix it as it silences legitimate warnings. However I can't really test any changes I make in an attempt to fixing this due to not having an older version of gcc. Thanks, Dimitrios _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel