On Thu, Sep 23, 2010, Mark Brown wrote: > On Wed, Sep 22, 2010 at 07:58:48PM -0700, Peter Hsiang wrote: > > > This patch adds the MAX98088 CODEC driver. > > > Signed-off-by: Peter Hsiang <peter.hsiang@xxxxxxxxxxxx> > > When you submitted the driver on the 31st of August my first comment in > the review was: > > | The major issue with this is that the driver needs to be updated to > | current ASoC versions - you should always be working against the trees > | that are in linux-next for new drivers. For ASoC you should be looking > | at: > > | git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git > > Currently you should be looking at for-next or for-2.6.37, though the > branch names will change as kernel development moves forward. What is the git command line path/parameter for for-next or for-2.6.37? Something equivalent to... ....pub/scm/linux/kernel/git/next/linux-next.git Why do the files in git/broonie/sound-2.6.git look older than -next? For example, it's missing soc-cache.c, and the codec drivers there use the old I/O method. Same drivers in -next are newer and use the soc-cache. > > This must be rectified before the driver can be considered for inclusion > in the kernel. As things stand the code will not compile. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
