On Thu, 9 Sep 2010, Kuninori Morimoto wrote: > > Dear Mark, Liam, Guennadi Hi Mark Feel free to add my Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> to these 6 patches. Thanks Guennadi > > These are ALSA V2 bug fix patches which are reported by Guennadi. > > Kuninori Morimoto (5): > fbdev: sh_mobile_hdmi: modify noisy comment out > fbdev: sh_mobile_hdmi: modify flags name to more specific > fbdev: sh_mobile_hdmi: modify snd_soc_dai_driver settings > fbdev: sh_mobile_hdmi: add new label for sound error path > ASoC: fsi-hdmi: remove unneeded header > > To Mark. > Please care above patch independently from these patches. > [PATCH 5/5] ASoC: fsi-ak4642: modiry platform_name > > These series are for ALSA side patches. > I will send SH side V2 patches soon. > > Main diff v1 <==> v2 is > I added Guennadi's report mail to log area on each patches, > and care more. > But these series still didn't care above. > I added reasons. > > -- Guennadi ------------------------------------------ > > +config SND_FSI_HDMI > > + bool "FSI-HDMI sound support" > > + depends on SND_SOC_SH4_FSI && FB_SH_MOBILE_HDMI > > + help > > + This option enables generic sound support for the > > + FSI - HDMI unit > > + > > "bool" means, if someone is linking the whole ASoC into the kernel, they > will not be able to build this as a module. Not a big deal, but you're > stealing some freedom from the user. > ------------------------------------------------------- > > understand. > But the config which use "bool" for FSI-XXX is not only FSI-HDMI. > So, I will care your indication as "new function patch" in future. > > > -- Guennadi ------------------------------------------ > With this config option you will have 3 SND_SOC_SH4_FSI implementations in > the Kconfig, all selectable independently. Do you really think it makes > sense and would work, if someone were to select more than one of those > options at the same time? > ------------------------------------------------------- > > Yes. I created it for independently. > For example, you can select FSI-AK4642 and FSI-HDMI in same time, > and both works well for me on AP4 board now. > > But I guess, if you select FSI-DA7210 and FSI-HDMI, > small patch which change FSIA <-> FSIB is needed. > > FSI-AK4642 : FSI-A > FSI-DA7210 : FSI-B > FSI-HDMI : FSI-B > > I think that it should be going to enable the selection of > "FSI-A" and "FSI-B" in the future. > But now, no way, no idea. > It is my task > > By the way, about HDMI sound, > I know that there are some HDMI monitors which can not use sound. > Now I'm debuging about it. > > -- Guennadi ------------------------------------------ > > + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE, > > Again, this I am not sure about. The datasheet says 16 to 32 bit are > possible, but then I only see configuration for 16 to 24 bits, but in any > case, I think, you'd want to implement .hw_params to support non-default > formats. > ------------------------------------------------------- > > Yes. I should modify this .formats. > But I can not select, test, support 32bit in current environment. > So, please put it to my TODO list. > > And yes. .hw_params implementation is important for advanced support. > But now, current HDMI sound support is still prototype (I didn't indicate though). > So. please put it to my TODO list too. > > Best regards > -- > Kuninori Morimoto > > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
