On Mon, Jul 26, 2010 at 7:44 PM, Liam Girdwood <lrg@xxxxxxxxxxxxxxx> wrote: > On Mon, 2010-07-26 at 16:37 +0900, Kyungmin Park wrote: >> On Mon, Jul 26, 2010 at 4:22 PM, Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote: >> > On Mon, Jul 26, 2010 at 3:57 PM, Mark Brown >> > <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: >> >> On 25 Jul 2010, at 19:07, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote: >> >> >> >>> This patch modify the name of I2S driver(S3C64XX/S3C24xx >> >>> /S3C2412) from "*-iis-*" to "*-i2s-*". The mismatch of I2S name >> >>> exist in the following sound driver. These files write the >> >>> "cpu_dai_name" of I2S as "*-i2s-*". >> >>> >> >>> - sound/soc/s3c24xx/aquila_wm8994.c : "s3c64xx-i2s-v4-dai" >> >>> - sound/soc/s3c24xx/goni_wm8994.c : "s3c64xx-i2s-v4-dai" >> >>> - sound/soc/s3c24xx/smdk64xx_wm8580.c "s3c64xx-i2s-v4-dai" >> >>> - sound/soc/s3c24xx/jive_wm8750.c : "s3c2412-i2s-dai" >> >>> - sound/soc/s3c24xx/neo1973_wm8753.c : "s3c24xx-i2s-dai" >> >>> - sound/soc/s3c24xx/neo1973_gta02_wm8753.c : "s3c24xx-i2s-dai" >> >>> - sound/soc/s3c24xx/s3c24xx_simtec_hermes.c : "s3c24xx-i2s-dai" >> >>> - sound/soc/s3c24xx/s3c24xx_simtec_tlv320aic23.c : "s3c24xx-i2s-dai" >> >>> - sound/soc/s3c24xx/s3c24xx_uda134x.c : "s3c24xx-i2s-dai" >> >>> - sound/soc/s3c24xx/smartq_wm8987.c : "s3c64xx-i2s-dai.0" >> >>> >> >>> or, It is should modify "cpu_dai_name" of sound drvier files >> >>> instead of modifying the name of I2S driver. >> >> >> >> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> >> >> >> >> but Jassi really should also comment here. >> > I already talked to Ben about renaming drivers but he doesn't like the idea >> > of breaking loadable drivers in distributions and I buy his opinion. >> > So, Ben really has the say on the matter. >> > > I'll explain the reasoning behind the "-dai" suffix. > > The "-dai" suffix name change is all about preventing naming collisions. > I'm not sure if this may affect the Samsung platforms atm, but it does > affect other platforms like OMAP, PXA, DaVinci, I.MX, FSL and Blackfin > atm. (Now that _all_ ASoC components are devices) > > The problem is that digital audio interfaces are typically now being > implemented in silicon as part of platform general purpose serial buses. > So on OMAP, we can use the McBSP interface for audio and any other > general purpose serial type data. So this leads to the problem where you > want to use McBSP2 for audio and McBSP1 for some non audio serial device > and have to name the McBSP client bus drivers for probing(). > > Btw shouldn't correct MODULE_ALIAS() information allow the distributions > to load the renamed module drivers ? > >> Plus how to change the directory name to "samsung'? >> > > I guess the s3c24xx directory name is actually quite misleading now. > Although this should probably be looked at after the multi-component > merge. > > Thanks > > Liam Since the changes due to multi-component support has already overridden the 'prohibitions' Ben had put in place and Ben doesn't seem to be bothered by these changes(no reply)... I guess we can move ahead with further cosmetic and name changing that people so long for ? _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
