Hello again.
And thanks for the comments.
Comments to comments:
> > +
> > +static int wl1273_probe(struct snd_soc_codec *codec)
> > +{
> > + struct wl1273_core **core = codec->dev->platform_data;
>
> Just curious, why is your platform data here not just a pointer to a
> struct wl1273 ?
You mean the naming? Wl1273 could be better, but as the whole
driver consists of the mfd core and the codec and the v4l2 child drivers
it was natural for me to name the central struct as wl1273_core.
> > + INIT_LIST_HEAD(&codec->dapm_widgets);
> > + INIT_LIST_HEAD(&codec->dapm_paths);
> > +
> > + codec->name = "wl1273";
> > + codec->num_dai = 1;
> > + codec->bias_level = SND_SOC_BIAS_OFF;
>
> Above 6 lines now done by core, so not needed now (I mentioned that for
> V5, but maybe not explicitly)
OK, I removed those lines now...
Thanks,
Matti
Matti J. Aaltonen (1):
ASoC: TI WL1273 FM Radio Codec.
sound/soc/codecs/wl1273.c | 525 +++++++++++++++++++++++++++++++++++++++++++++
sound/soc/codecs/wl1273.h | 101 +++++++++
2 files changed, 626 insertions(+), 0 deletions(-)
create mode 100644 sound/soc/codecs/wl1273.c
create mode 100644 sound/soc/codecs/wl1273.h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
