On Sat, Aug 7, 2010 at 17:08, Mark Brown wrote: > On 7 Aug 2010, at 21:28, Mike Frysinger <vapier@xxxxxxxxxx> wrote: > >> +config SND_BF5XX_SOC_ADAU1361 >> + tristate "SoC ADAU1361 Audio support" >> + depends on SND_BF5XX_I2S >> + select SND_BF5XX_SOC_I2S >> + select SND_SOC_ADAU1361 >> + select I2C >> + help >> + Say Y if you want to add support for ADAU1361 SoC audio. >> + > > Identical comments to the last machine driver you posted here. > > It'd be really helpful if you could do a bit more pre-review on the stuff you're posting, especially where you've got a bunch of drivers that follow similar patterns and are going to generate exactly the same feedback. Posting a large batch of patches at once isn't a problem but if you're sending additional patches later on it'd be helpful to take into account the feedback that has already been given on prior serieses. probably, but i'm not familiar with the ASoC stuff to fix/review any of this. i'll open another tracker item for these codecs. -mike _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
