On Thu, Aug 05, 2010 at 09:07:50AM +0300, Peter Ujfalusi wrote: > Move the DAPM initialization after the machine driver has > finished it's init (dai_link driver). > Since in machine init we can add DAPM widgets we need to > take them into account as well. > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> but... > @@ -1375,6 +1372,10 @@ static int soc_probe_dai_link(struct snd_soc_card *card, int num) > } > } > > + /* Make sure all DAPM widgets are instantiated */ > + snd_soc_dapm_new_widgets(codec); > + snd_soc_dapm_sync(codec); > + > /* register the rtd device */ > rtd->dev.init_name = rtd->dai_link->stream_name; > rtd->dev.release = rtd_release; ...it'd be better to find a home for this that was per card rather than per link I guess, that way we only need to iterate through once during instantiation. A bit irrelevant though given that it's hardly a hot path. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel