Hello. New in the fifth version: > > > +/* codec private data */ > > > +struct wl1273_priv { > > > + struct snd_soc_codec codec; > > > + enum wl1273_mode mode; > > > + struct wl1273_core *core; > > > + unsigned int channels; > > > +}; > > > > ...why would anything outside the driver be peering into this? > > Well, I see no reason... So I'll move it from the header to the c -file > and then it's fine? OK... that's most probably what you mean. So I've moved the private struct definition from the header to the code file. And following the same logic I also moved the mode enum definition. Cheers, Matti A. Matti J. Aaltonen (1): ASoC: TI WL1273 FM Radio Codec. sound/soc/codecs/wl1273.c | 552 +++++++++++++++++++++++++++++++++++++++++++++ sound/soc/codecs/wl1273.h | 30 +++ 2 files changed, 582 insertions(+), 0 deletions(-) create mode 100644 sound/soc/codecs/wl1273.c create mode 100644 sound/soc/codecs/wl1273.h _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel