On Sat, 2010-07-24 at 11:46 +0200, ext Liam Girdwood wrote: > On Sat, 2010-07-24 at 11:05 +0300, Matti J. Aaltonen wrote: > > Hi. > > > > On Fri, 2010-07-23 at 20:24 +0200, ext Liam Girdwood wrote: > > > On Fri, 2010-07-23 at 15:42 +0300, Matti J. Aaltonen wrote: > > > > Hello all. > > > > > > > > Thank you for comments and thanks to Peter for advice on constraints > > > > and ALSA in general. > > > > > > > > New in this version: > > > > > > > > 1. Now constraints are used in the start-up function. It wasn't as big > > > > a deal as I thought... Also now the codec is always in full duplex > > > > mode. But it still refuses to do the wrong thing with FM as real full > > > > duplex is then impossible. > > > > > > > > 2. Fixed the exported mode support function. The name in now > > > > wl1273_get_format and it returns the audio interface format. > > > > > > > > 3. Removed the remaining obsolete functions. > > > > > > > > 4. Not actually new but... > > > > > > > > >> I didn't do this yet. But could you give me the git URL and then > > > > >> I'll resend? > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/lrg/sound-2.6.git > > > > > > > > I tried the corresponding http URL > > > > > > > > http://www.kernel.org/pub/scm/linux/kernel/git/lrg/sound-2.6.git but > > > > got > > > > > > > > fatal: > > > > http://www.kernel.org/pub/scm/linux/kernel/git/lrg/sound-2.6.git/info/refs > > > > not found: did you run git update-server-info on the server? > > > > > > > > > > Oh, that's the wrong URL. The correct one is :- > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/lrg/asoc-2.6.git > > > > > > Can you re-do against multi-component. The changes all relate to probe() > > > and remove(). > > > > Yes. No problem... I actually woke up last night and realized that the > > format function I wrote didn't have a NULL pointer check for the value > > parameter... So please ignore the v2. patch. I'll send version v2.B > > soon... > > > > Ok, thanks. > > Btw, now that we have a naming convention for components how about this > having a "-radio" or "-fm" device suffix ? That's not a problem either. I also noticed when comparing to other codecs that some function names could be better... But I saw that there are quite a lot changes that need to be done... so this is something I can't do in a couple of hours. I'll go back to my vacation and do it properly when I come back... after one week. B.R. Matti > > Liam _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
