Hello. On Thu, 2010-07-22 at 15:05 +0200, ext Mark Brown wrote: > On Thu, Jul 22, 2010 at 02:11:27PM +0200, matti.j.aaltonen@xxxxxxxxx wrote: > > > >You've still not provided any information about what use this will be > > >put to. > > > Yes, sorry I didn't get your point. I guess I tought that it's irrelevant, what > > the soc_card driver actually does. But it actually does this: > > OK, so the DAI format for the CODEC changes dependant on the mode. For > this I'd suggest just changing the function to actually export the DAI > format directly rather than requring all users to replicate the lookup > you've currently got in your driver. This makes it clear what the > purpose of providing the export is and avoids external drivers needing > to know too much about the internals of this one. Ok, that makes perfect sense... > In terms of what's relevant if someone's asking questions like this > they're normally trying to figure out what your high level goal is > because your code looks suspicous and are trying to understand the > purpose of the code so they can suggest a way of doing things that is > more in line with the intentions of the surrounding code. Sorry, I didn't mean to be difficult... If this was my personal project I'd have sent you every bit my code at once. Cheers, Matti A. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
