Hi Mark, On Thu, Jul 15, 2010 at 6:32 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Jul 15, 2010 at 05:58:47PM +0900, Seungwhan Youn wrote: > >> + i2s->base = S3C64XX_PA_IISV4; >> + > > I'd really expect this to be being pulled from the resources for the > platform device for the DAI rather than hard coded into the driver. If > we're going to start reorganising things like this and touching all the > drivers it'd seem better to go straight to doing that rather than > introducing this approach. > Does your comment means that 'i2s->base' get base address from the resources for the platform device using 'platform_get_resources()'? I'm doing on preparing that issue into another patch already (because I think this patch is only for Liam's multi-comp, not for that issue). If the resource should get from platform device, I'll be happy to make a new one. Thanks. Claude. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
