Dear Mark Thank you for your checking patch. At first, I will re-send v2 patches as "bug fix" and "add XXX". > > +#define SH_FSI_FMT_MONO_DELAY (2 << 0) > > +#define SH_FSI_FMT_PCM (3 << 0) > > +#define SH_FSI_FMT_I2S (4 << 0) > > +#define SH_FSI_FMT_TDM (5 << 0) > > +#define SH_FSI_FMT_TDM_DELAY (6 << 0) > > Wouldn't it be clearer to just define these as straight numbers? Sorry. Do you mean (1 << 0) is needed ? (1 << 0) is not changed from old one -------------------------------- #define SH_FSI_FMT_MONO (1 << 0) <=== -#define SH_FSI_FMT_MONO_DELAY (1 << 1) -#define SH_FSI_FMT_PCM (1 << 2) -#define SH_FSI_FMT_I2S (1 << 3) -#define SH_FSI_FMT_TDM (1 << 4) -#define SH_FSI_FMT_TDM_DELAY (1 << 5) +#define SH_FSI_FMT_MONO_DELAY (2 << 0) +#define SH_FSI_FMT_PCM (3 << 0) +#define SH_FSI_FMT_I2S (4 << 0) +#define SH_FSI_FMT_TDM (5 << 0) +#define SH_FSI_FMT_TDM_DELAY (6 << 0) -------------------------------- Best regards -- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel