Jassi Brar wrote: > On Thu, Jul 8, 2010 at 1:57 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote: >> This patch add sound support for the Aquila board based on S5PC110. >> >> The Aquila board is based on Samsung SoC(S5PC110) and include >> WM8994 codec over I2Sv5 to support sound. As there is currently >> no driver for the I2Sv5, the code to use I2Sv5 is deleted >> on this patch. >> >> After I2Sv5 driver is posted in a few weeks, I will post incremental >> patch which some codes for using I2Sv5. The owner of I2Sv5 said that >> he will post I2Sv5 driver after a few weeks. > > I don't plan to create a copy of an almost copy of s3c64xx-i2s.c > Please try to use the existing sound/soc/s3c24xx/s3c64xx-i2s-v4.c > I intend to only enhance that code to enable features of 'v4', 'v5' etc. > As your comment, I did modify some codes to use sound/soc/s3c24xx/ s3c64xx-i2s-v4.c instead of I2Sv5. When I try to compile kernel with arch/arm/configs/s5pv210_defconfig. diff --git a/sound/soc/s3c24xx/Kconfig b/sound/soc/s3c24xx/Kconfig index 0c5d8a5..c09b402 100644 --- a/sound/soc/s3c24xx/Kconfig +++ b/sound/soc/s3c24xx/Kconfig @@ -135,6 +135,7 @@ config SND_S3C64XX_SOC_SMARTQ config SND_S5PC110_SOC_AQUILA_WM8994 tristate "SoC I2S Audio support for AQUILA - WM8994" depends on SND_S3C24XX_SOC && MACH_AQUILA + select SND_S3C64XX_SOC_I2S_V4 select SND_SOC_WM8994 help Say Y if you want to add support for SoC audio on aquila diff --git a/sound/soc/s3c24xx/s3c-i2s-v2.c b/sound/soc/s3c24xx/s3c-i2s-v2.c index 13311c8..64376b2 100644 --- a/sound/soc/s3c24xx/s3c-i2s-v2.c +++ b/sound/soc/s3c24xx/s3c-i2s-v2.c @@ -32,7 +32,8 @@ #undef S3C_IIS_V2_SUPPORTED -#if defined(CONFIG_CPU_S3C2412) || defined(CONFIG_CPU_S3C2413) +#if defined(CONFIG_CPU_S3C2412) || defined(CONFIG_CPU_S3C2413) \ + || defined(CONFIG_CPU_S5PV210) #define S3C_IIS_V2_SUPPORTED #endif When compiling kernel, it is occurred below error because arch/arm/mach-s5pv210/include/mach/gpio-bank-*.h file isn't included to upstream kernel. sound/soc/s3c34xx/s3c64xx-i2s-v4.c included the header files in arch/arm/mach-s3c64xx/include/*. What is your opinion for this error? - compile error log : CHK include/generated/compile.h CC sound/soc/s3c24xx/s3c64xx-i2s-v4.o sound/soc/s3c24xx/s3c64xx-i2s-v4.c:19: fatal error:mach/gpio-bank-c.h: No such file or directory Thank you, Chanwoo Choi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
