On Thu, Jul 08, 2010 at 01:57:38PM +0900, Chanwoo Choi wrote: > This patch add sound support for the Aquila board based on S5PC110. > > The Aquila board is based on Samsung SoC(S5PC110) and include > WM8994 codec over I2Sv5 to support sound. As there is currently > no driver for the I2Sv5, the code to use I2Sv5 is deleted > on this patch. This looks good from my point of view, though I'm not sure if you want to do any updates for Jassi's comments and Liam also needs to review still. One other thing that you might want to do - I'm not sure if you noticed but there is now an API call snd_soc_dapm_ignore_suspend() which allows audio paths to be kept up while the system is suspended, intended for use in cases like voice calls on mobile phones where audio is running even though the Linux system is suspended. To use this you should mark all DAPM endpoints which can be live over suspend as ignoring suspend then ASoC should transparently keep any paths between endpoints marked this way up. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
