Mark Brown wrote:
> On Wed, Jul 07, 2010 at 05:41:30PM +0900, 최찬우 wrote:
>
>> +static const struct snd_kcontrol_new aquila_controls[] = {
>> +};
>
> This should be removed until there are controls to go in it.
>
Ok, I will do.
>> +static int aquila_wm8994_init(struct snd_soc_codec *codec)
>> +{
>> + int ret;
>> + unsigned int reg;
>
> It'd probably be useful to list any unconnected pins here (if there are
> any) using snd_soc_nc_pin().
>
I add unconnected pins using snd_soc_nc_pin().
> Otherwise this all looks very good - you should probably also include a
> signoff from Mr. Shim, I guess.
I will include Mr. Shim to signoff.
Thank you for your comment.
Chanwoo Choi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
