Re: [PATCH 3/4] ALSA: usb-audio: parse UAC2 sample rate ranges correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Fri, 11 Jun 2010 17:46:33 +0200,
Daniel Mack wrote:
> 
> On Fri, Jun 11, 2010 at 05:43:04PM +0200, Takashi Iwai wrote:
> > At Fri, 11 Jun 2010 17:34:21 +0200,
> > Daniel Mack wrote:
> > > 
> > > +		/*
> > > +		 * for ranges with res == 1, we want a continuous sample
> > > +		 * rate range, so this function should return 0.
> > > +		 */
> > > +		if (res == 1) {
> > > +			fp->rates = SNDRV_PCM_RATE_CONTINUOUS;
> > > +			return 0;
> > 
> > Missing setup of fp->rate_min and fp->rate_max here?
> 
> Gna, not my day. I did that, and of course tested it with a modified
> firmware and it worked well.
> 
> But appearantly I exported the wrong patch. Sorry.

Well, people can understand it if they see the current score of the
opening football game ;)


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux