Hello. Wan ZongShun wrote: > Dear all, > Use the resource_size function instead of manually calculating the > resource size. This reduces the chance of introducing off-by-one > errors. > In addition, to use __devinit and __devexit is good too. "Good" isn't a good justification I think. Also, this just asks to be put into two patches instead of one as the patch does two completely different things. > Signed-off-by:Wan ZongShun<mcuos.com@xxxxxxxxx> WBR, Sergei _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel