Re: [PATCH 1/3] add API to allow disabling period interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks good. Using the .info field is probably better than adding a new
one as I did. One correction though:

> +       runtime->no_period_irq =
> +                       !!(params->flags & SNDRV_PCM_HW_PARAMS_NO_PERIOD_IRQ);

An additional test is needed here so that the capabilities of the
hardware are double-checked

if (params->info & SNDRV_PCM_INFO_NO_PERIOD_IRQ)
     runtime->no_period_irq = !!(params->flags &
SNDRV_PCM_HW_PARAMS_NO_PERIOD_IRQ);
else
    runtime->no_period_irq = 0;
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux