Re: [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 05 May 2010 13:02:03 ext Jarkko Nikula wrote:
> Signed-off-by: Jarkko Nikula <jhnikula@xxxxxxxxx>
> 
> ---
> 
> v2:
> 
> - Removed added regulator_bulk_disable brain fart from aic3x_i2c_probe
> - Added comment to gpio_reset number in aic3x_pdata

Would have been nice to have a commit message for this just in case.
Something like this would do:
Handle the reset GPIO within the codec driver in order to follow the startup 
protocol for the tlv320aic3x codecs.

Can you Liam add this message (if Jarkko agrees)?

I can give my:
Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>
Or
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>

Whichever you feel appropriate in case of the tlv320aic3x codec driver.

-- 
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux