Re: [PATCH] ASoC: tlv320aic3x: Add platform data and reset gpio handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 5 May 2010 12:35:55 +0300
Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> wrote:

> >  err_enable:
> >  	regulator_bulk_free(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
> >  err_get:
> > +	regulator_bulk_disable(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
> 
> This looks suspicious (disable after free?)
> On the other hand, is there a need to disable at all in error case?
> 
Oops. How that went there. Thanks for noticing!


-- 
Jarkko
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux