On Fri, Apr 30, 2010 at 01:10:14PM +0300, Peter Ujfalusi wrote: > On Friday 30 April 2010 12:56:37 ext Mark Brown wrote: > > Then just use > > the hooks in the normal audio stream bringup/teardown surely? It's > > possible that I'm missing something as a result of your list of use > > cases but I'd expect this to flow fairly naturally from the normal call > > flow. > The thing is, that I want to handle the chip power in one place, and > dac33_set_bias_level is a really good place for that. Sure, but it shouldn't need to be worrying about playback at all. > At the time when pcm_prepare is called the codec is still in OFF. > So I just postponed the dac33_prepare_chip call for later, when the codec > switches BIAS level. > Than I enable the power and if there is a stream, than I do the preparation. > Note: the BIAS level change is still within the pcm_prepare call chain... Surely a much more straightforward solution to this is just to add a post-DAPM prepare() callback to the DAI ops? It seems like a perfectly reasonable thing to have that callback and it means you can rely on the existing mechanisms having taken care of the power for you. > In this way I don't need to do any additional housekeeping while managing the > power of the codec. My point here is that it seems like you need to do more housekeeping than you should :) _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
