Re: [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 28, 2010 at 8:57 AM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:

> I'm just saying move the registration of the machine device out of
> arch/powerpc platform code and into the ssi driver.

But the SSI driver is an OF driver, and it gets probed for every SSI
node in the device tree.  On the 8610, that means being probed twice.
But I should only call platform_device_register_simple() once.

Are you saying that I should call platform_device_register_simple()
from the SSI's driver initialization function, fsl_ssi_init()?

> Then you've got a
> reasonable place to pass shared data (either the ssi device node or
> device instance or name.  Whatever you need) to the machine driver.

The problem is that the fabric driver needs much more information from
the device tree than the SSI driver needs.  So if the SSI driver is
going to pass that information to the fabric driver via the platform
data, it's going to have to know what information the fabric driver
needs.  Then the SSI driver is not board-independent.

-- 
Timur Tabi
Linux kernel developer at Freescale
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux