On Mon, Mar 22, 2010 at 01:50:08PM +0800, Barry Song wrote: > On Fri, Mar 19, 2010 at 8:24 PM, Mark Brown > > - The way you've factored out the bus probe and removal functions so > > that there's no code in the individual I2C and SPI functions means > > that the register() and unregister() functions could just be squashed > > into the bus_probe() and bus_remove() functions - all that the > > register and unregister functions are is the code that's shared > > between the bus > if so, it likes register/unregister should be moved into probe/remove > even for codecs with single codec? I'm assuming you mean single bus? If the code is structured like yours with nothing in the per-bus probe/remove then definitely. Note that sometimes drivers do keep a split for multiple buses since the hardware supports multiple buses but they've not all been implemented yet. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
