On Wed, Mar 10, 2010 at 7:51 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, Mar 10, 2010 at 04:48:57PM +0900, Jassi Brar wrote: >> In order for the RATE and FMT defines to be reuseable in future by the >> i2sv4 driver, move the MACROs out to the header file. > > I'll apply this but for the rates... > >> -#define S3C64XX_I2S_RATES \ >> - (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 | SNDRV_PCM_RATE_16000 | \ >> - SNDRV_PCM_RATE_22050 | SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 | \ >> - SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 | SNDRV_PCM_RATE_96000) > > This is just SNDRV_PCM_RATE_8000_96000 anyway so may as well use it > directly. Of course. Btw, I was thinking of adding RATE_KNOT too, as it is usually possible to achieve 'not so standard' 12000 and 24000 rates, besides the flag doesn't 'promise' anything about availability of rates. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
