On Wed, Mar 10, 2010 at 04:49:06PM +0900, Jassi Brar wrote: > While adding support for new SoCs' I2S, check for the blocks > of older SoCs that have similar feature and set the flag for > that feature. As a result of this... > +/* Set this flag for I2S controllers that have the bit IISMOD[12] > + * bridge/break RCLK signal and external Xi2sCDCLK pin. > + */ > +#define S3C_FEATURE_CDCLKCON (1 << 0) > + ...I'd suggest moving this into the patch that adds support for CDCLKCON (or merging that patch in with this one). Probably worth namespacing these defines a bit more (eg, S3C_IIS_) since I'd expect they'll end up being used by the arch/arm code too in the platform data definition. They ought to be in include/sound or arch/arm for visibility to arch/arm code too. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
