On Wed, 2010-03-10 at 17:31 +0900, jassi brar wrote: > On Wed, Mar 10, 2010 at 5:24 PM, Liam Girdwood <lrg@xxxxxxxxxxxxxxx> wrote: > > On Wed, 2010-03-10 at 16:48 +0900, Jassi Brar wrote: > >> The header with I2S register map and bit definitions has been copied > >> to where the drivers are(sound/soc/s3c24xx/) since the header has nothing > >> usable for platform code. Also, it will help avoid need for co-ordination > >> between ASoC and S3C ARCH trees. For now, the header regs-s3c2412-iis.h > >> is left intact but rendered useless by making ASoC drivers include the > >> newly copied version of it (sound/soc/s3c24xx/regs-i2s-v2.h) Later the > >> header could be dropped by patches to S3C PLAT tree. > >> > > > > I'm not too keen on moving CPU register and bit definitions out of ARCH. > The header doesn't contain absolute register addresses, but only > offsets. Isn't this really the same thing ? > The base address of I2S controllers are defined in PLAT > specific header. So, I think we can move the header. I don't think your reason of "co-ordination between ASoC and S3C ARCH trees" can justify breaking kernel policy. Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
