On Thu, Mar 4, 2010 at 10:24 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Mar 04, 2010 at 10:18:59PM +0900, jassi brar wrote: >> On Thu, Mar 4, 2010 at 9:05 PM, Mark Brown > >> > +static long s3c2412_i2s_delay(struct snd_pcm_substream *substream, >> > + ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??struct snd_soc_dai *dai) > >> return type snd_pcm_sframes_t ? > > Meh, yeah. It's actually the same type underneath. of course, but still... >> I am trying to make functions in s3c-i2s-v2.c re-entrant as much as possible, >> 'delay' too seems to be a good candidate. > > Could you expand on what you mean by this? I mean, 'delay' is such a trival func that it can perhaps do controller specific stuff after checking some flag(new) in s3c_i2sv2_info. > All we're doing here is > directly reporting a value read from a memory mapped register so there's > nothing to be worried about from a locking point of view unless there > were a multi-core system and the bus to the IP needed some locking, > which is vanishingly unlikely to ever happen. As I said, I am OK. I just see this func being modified soon to handle i2sv4 too. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
