On Wed, Mar 03, 2010 at 02:46:25PM +0800, Takashi Iwai wrote: > At Tue, 2 Mar 2010 13:43:07 +0800, > Wu Fengguang wrote: > > > > On Mon, Mar 01, 2010 at 07:27:53PM +0800, Wei Ni wrote: > > > Hi, Takashi > > > I developed the hdmi audio driver for new chipset MCP89 and GT21x. > > > The new HAD controller and codec support standard HDMI operation. > > > > > > I attached the patch file, please check it. > > > > Wei Ni, > > > > Can we avoid the big copy&paste and do more code reuse? > > This benefits all of us in long term. > > The plan is to merge all current patch_*hdmi.c into one. > But this can be done later once after we get the working driver > for the new Nvidia codecs. > > The new Nvidia HDMI codec is a bit tricky (which has 4 separate > codec slots), so I'd like to get it working first. OK, it makes sense to solve one problem at a time. Wei Ni, would you ensure these naming rules: - unmodified functions: keep the original function name hdmi_* (if the original function name is intelhdmi_*, rename it to hdmi_*) - modified function: rename function name to nvhdmi_* (if the original function name is hdmi_*, rename it to intel_hdmi_*) And do the same for data structures, enums, variables, etc. This hopefully will make it easier to do the future merge. Thanks, Fengguang _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
