On Fri, 2010-02-19 at 16:03 +0200, Jarkko Nikula wrote: > On Fri, 19 Feb 2010 10:35:25 +0000 > Liam Girdwood <lrg@xxxxxxxxxxxxxxx> wrote: > > > > @@ -156,11 +158,7 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream) > > > return 0; > > > > > > memset(&dma_params, 0, sizeof(dma_params)); > > > - /* > > > - * Note: Regardless of interface data formats supported by OMAP McBSP > > > - * or EAC blocks, internal representation is always fixed 16-bit/sample > > > - */ > > > > Perhaps this should be rewritten to reflect mcbsp and mcpdm users rather > > than deleted. > > > I'm fine with the deletion. AFAIK there is no public specs for the EAC > (at least not for the OMAP2420) so I see this comment only confusing > (I wrote it) and a person who would write DAI driver for the EAC most > probably has accesses to the specs. > Ok, that's fine. Jorge, now it's only patch 2/3 requiring a little work. Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel