On Thu, Feb 18, 2010 at 03:12:53PM +0900, Joonyoung Shim wrote: > On 2/17/2010 7:52 PM, Mark Brown wrote: > > What modifications are you looking for here? ASoC doesn't make any > Thing modified is the active counting of DAI(struct snd_soc_dai) and pcm > stream(struct snd_soc_pcm_stream). Also, startup() in ops functions of > same DAI shouldn't be called several times when the device using same > DAI is opened. Yeah, though it's not 100% clear to me that the multiple calls to startup() are a bad thing - if the driver does need to coordinate between multiple possible links then this gives it an opportunity to handle that. On the other hand it's likely to be easier for drivers that do allocations on startup() if there are separate callbacks for first reference and for each use. > > can be turned on and off, for example) but these should be things that > > could be open coded in individual drivers. > Sorry, what does "be open coded" mean? Explicitly written in individual drivers rather than being factored out or otherwise using common code. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
