michael@xxxxxxxxxxxxx (Michaël Cadilhac) writes: > Takashi Iwai <tiwai@xxxxxxx> writes: > >> At Mon, 11 Jan 2010 13:35:19 -0500, >> Michaël Cadilhac wrote: >>> >>> michael@xxxxxxxxxxxxx (Michaël Cadilhac) writes: >>> >>> > michael@xxxxxxxxxxxxx (Michaël Cadilhac) writes: >>> > >>> >> So, my final saying is the following patch. It fixes the segfault on >>> >> stopping a non-started usb_stream, plus it adds the ability to set a >>> >> period size and sound rate. The latter offers a workaround for the >>> >> second issue I came with (that the default values for period bytes, and >>> >> hence period size, were too high for us122l to work). >>> > >>> > Any comment on that patch would be greatly appreciated. I'm just >>> > wondering if it's safe for me to give it to some people. >>> >>> Anyone? Note that this also fixes a real bug, so it might be of >>> interest to include it in the trunk. >> >> Through a quick glance, the patch looks OK to me. >> Could you give a proper subject and changelog to merge your patch >> to git tree? > > Hi there Takashi, and sorry for the delay. Here are the patch, > subdivised in two distinct logical changes. I hope the format is what > you asked for. Pinging. IIUC, I forgot to include "subject" lines. The first one should be "usb_stream: Check for NULL-ness before dereferencing", and the second one "usb_stream: Allow user-set period-size and rate.". -- Michaël `Micha' Cadilhac (LITQ, U. de Montréal) -- http://michael.cadilhac.name || Perhaps we should start making protest releases || before doing a fall release. || -- David Kastrup _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
