Re: [PATCHv2 05/10] ASoC: AC97: SMDK: Add wm9713 machine driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 27, 2010 at 02:59:19PM +0900, jassisinghbrar@xxxxxxxxx wrote:

> +	Headphone Playback Switch - On
> +	$ amixer cset numid=4 1
> +

Actually, one thing that really needs fixing here - these instructions
refer to the controls by number.  This is extremely fragile in the face
of any changes in the CODEC driver since the control numbering is worked
out at runtime and any change in the set of controls exported by the
device may change the result.  It is much better to refer to the
controls by name since the names are much less likely to change.  This
is also helpful for people using other UIs which don't display the
control names.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux