On Wed, 27 Jan 2010, Clemens Ladisch wrote: > Jaroslav Kysela wrote: >> I returned hw_ptr_interrupt variable back. I am testing this patch now: >> >> http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=04d64a69fcb9fd182d73d6f1a8de55b2f527a1de >> >> A review is always welcome. Thanks. > > The patch looks fine, and it works again now. > > > A somewhat unrelated issue: Both old and new code assume that > hw_ptr==0 is a period boundary, but that is not true if the boundary > is not an integer multiple of the period size, and the pointer wraps. > I'm not sure what happens then. I'm not exactly sure what you're talking about. Where is the hw_ptr==0 assumption? I see wrapping only for hw_base which is good, because this value is based on buffer_size. Thanks, Jaroslav ----- Jaroslav Kysela <perex@xxxxxxxx> Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
